Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(date): add hints how to generate date ranges #3128

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 22, 2024

Picks up a suggestion from #3107 and explains how date ranges can be generated easily.

Preview: https://deploy-preview-3128.fakerjs.dev/api/date.html#overview

grafik

Not sure, about the phrasing and location of the text.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: date Something is referring to the date module labels Sep 22, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 22, 2024
@ST-DDT ST-DDT requested review from a team September 22, 2024 08:54
@ST-DDT ST-DDT self-assigned this Sep 22, 2024
Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 800fed7
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/670850b54d90be0008f120d2
😎 Deploy Preview https://deploy-preview-3128.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (d516392) to head (800fed7).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3128      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2797     2797              
  Lines      227777   227777              
  Branches      581      577       -4     
==========================================
- Hits       227702   227692      -10     
- Misses         75       85      +10     
Files with missing lines Coverage Δ
src/modules/date/index.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Sep 23, 2024
@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Oct 10, 2024
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team October 10, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: date Something is referring to the date module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants