Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vehicle): add more non-US vehicle manufacturers #3173

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

matthewmayer
Copy link
Contributor

fix #2881

@matthewmayer matthewmayer requested a review from a team as a code owner October 12, 2024 02:06
@matthewmayer matthewmayer added p: 1-normal Nothing urgent m: vehicle Something is referring to the vehicle module labels Oct 12, 2024
Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 4971eb0
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6709ee6644a3f500096d2354
😎 Deploy Preview https://deploy-preview-3173.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

GitHub Actions has found some problems running the preflight checks.

Please make sure to:

  • run pnpm run preflight locally
  • fix all issues until the command completes without errors
  • commit and push the changes

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (25506d2) to head (4971eb0).

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #3173    +/-   ##
========================================
  Coverage   99.96%   99.97%            
========================================
  Files        2797     2797            
  Lines      227777   227787    +10     
  Branches      577      959   +382     
========================================
+ Hits       227698   227723    +25     
+ Misses         79       64    -15     
Files with missing lines Coverage Δ
src/locales/en/vehicle/manufacturer.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m: vehicle Something is referring to the vehicle module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vehicle data is very US-centric
1 participant