Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(github): add github actions #35

Merged
merged 2 commits into from
Jan 9, 2022
Merged

feat(github): add github actions #35

merged 2 commits into from
Jan 9, 2022

Conversation

ericjeker
Copy link
Contributor

Proposal for #1

I just added testing and linting for now.

@Shinigami92
Copy link
Member

It's a start and we can improve it later on 👍

damienwebdev
damienwebdev approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 9, 2022
@Shinigami92 Shinigami92 linked an issue Jan 9, 2022 that may be closed by this pull request
ci: Add Github Actions pipeline #1
Closed
@prisis
Copy link
Member

prisis commented Jan 9, 2022

What node versions should we support?

@Shinigami92
Copy link
Member

before end of march: 12, 14, 16 and 17 + mac 16 + win 16
after end of march we could drop 12

But do we have relevant stuff for differences between unix and win?

@Shinigami92
Copy link
Member

For references:
Vite: https://github.com/vitejs/vite/blob/main/.github/workflows/ci.yml
My project: https://github.com/prettier/plugin-pug/blob/main/.github/workflows/ci.yml

Shinigami92
Shinigami92 requested changes Jan 9, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Shinigami92
Copy link
Member

It's currently expected that CI test are failing!
We already have #12 for that, but want to see that it takes effect

@damienwebdev damienwebdev merged commit c788890 into faker-js:main Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@damienwebdev damienwebdev damienwebdev approved these changes

Assignees
No one assigned
Labels
c: chore PR that doesn't affect the runtime behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: Add Github Actions pipeline
4 participants
@ericjeker @Shinigami92 @prisis @damienwebdev