updated propTypes for height and width to be union type of string and number. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… number. Also added jest test check no warnings happen when a string is used
fakiolinho
reviewed
Jun 7, 2018
lib/__tests__/react-loading.spec.jsx
Outdated
| @@ -1,5 +1,6 @@ | |||
| import React from 'react'; | |||
| import { shallow } from 'enzyme'; | |||
| import sinon from 'sinon'; | |||
There was a problem hiding this comment.
Do we need sinon since we have jest? Not sure but i think that this might work:
jest.spyOn(global.console, 'error')
fakiolinho
reviewed
Jun 7, 2018
| @@ -8,8 +8,14 @@ export default class Loading extends Component { | |||
| color: PropTypes.string, | |||
| delay: PropTypes.number, | |||
| type: PropTypes.string, | |||
| height: PropTypes.number, | |||
| width: PropTypes.number, | |||
| height: PropTypes.oneOfType([ | |||
There was a problem hiding this comment.
Looks good. Could you please update readme.md accordingly. I think we need 1-2 examples to make this clear because i can see that many people get confused by these 2 props values. What do you think?
|
@fakiolinho @dcgudeman any idea when this might be merged? |
|
@kgodey I can probably make the requested changes this weekend. After that it will be up to @fakiolinho |
|
@fakiolinho let me know if there are anymore changes you would like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added jest test check no warnings happen when a string is used. This required adding sinon as a dependency.