Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 provide automatic snaplen values #19

Conversation

fako1024
Copy link
Owner

@fako1024 fako1024 commented Mar 28, 2023

Filed against #17 because this branch is based off that (PR #17 pending). Basically replaces the simple fixed integer value for the capture length (a.k.a. snaplen) with a functional approach that is not limited to setting a fixed value but allows the respective source to automatically choose the optimal snaplen based on a strategy (taking into account the link type and e.g. what the user intents to do with the captured data).

Closes #11

@fako1024 fako1024 added the enhancement New feature or request label Mar 28, 2023
@fako1024 fako1024 added this to the Initial Release (v1) milestone Mar 28, 2023
@fako1024 fako1024 requested a review from els0r March 28, 2023 08:34
@fako1024 fako1024 self-assigned this Mar 28, 2023
@fako1024
Copy link
Owner Author

@els0r Friendly ping, if you have a moment to spare... 🙏

Copy link
Collaborator

@els0r els0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings from Steve

@fako1024
Copy link
Owner Author

fako1024 commented Apr 1, 2023

Greetings from Steve

Thx, give him my regards! 👋

@fako1024 fako1024 merged commit 80b8c15 into 15-16-pcap-reader-zero-overhead-mock Apr 1, 2023
@fako1024 fako1024 deleted the 11-provide-automatic-snaplen-values branch April 1, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants