Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Add missing interface wrap for SourceZeroCopy #21

Merged
merged 2 commits into from
Apr 15, 2023
Merged

[bugfix] Add missing interface wrap for SourceZeroCopy #21

merged 2 commits into from
Apr 15, 2023

Conversation

fako1024
Copy link
Owner

Quick fix for an obvious lapse on my part: I forgot to wrap the generic / common Source in the new SourceZeroCopy interface, making it quite hard to use the latter as a Source across the codebase 😛

@els0r I'd greatly appreciate an "AFK"-style approval 😉

@fako1024 fako1024 added the bug Something isn't working label Apr 15, 2023
@fako1024 fako1024 added this to the Initial Release (v1) milestone Apr 15, 2023
@fako1024 fako1024 requested a review from els0r April 15, 2023 10:54
@fako1024 fako1024 self-assigned this Apr 15, 2023
els0r
els0r approved these changes Apr 15, 2023
View reviewed changes
Copy link
Collaborator

@els0r els0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings from the Windy City

@fako1024 fako1024 merged commit 616b95f into main Apr 15, 2023
@fako1024 fako1024 deleted the fako1024-fix-missing-source-interface-wrap branch April 15, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@els0r els0r els0r approved these changes

Assignees

@fako1024 fako1024

Labels
bug Something isn't working
Projects
None yet
Milestone
Initial Release (v1)
Development

Successfully merging this pull request may close these issues.
2 participants
@fako1024 @els0r