Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Remove unnecessary allocation in ring buffer block retrieval #44

Merged
merged 1 commit into from
May 21, 2023
Merged

[feature] Remove unnecessary allocation in ring buffer block retrieval #44

merged 1 commit into from
May 21, 2023

Conversation

fako1024
Copy link
Owner

@els0r A tiny improvement that makes the whole capture routine via afring completely free of allocations (except initial setup of course).

Closes #43

@fako1024 fako1024 added the performance Performance / optimization related topics label May 20, 2023
@fako1024 fako1024 added this to the Initial Release (v1) milestone May 20, 2023
@fako1024 fako1024 requested a review from els0r May 20, 2023 11:31
@fako1024 fako1024 self-assigned this May 20, 2023
@fako1024 fako1024 linked an issue May 20, 2023 that may be closed by this pull request
Make afring capture zero-allocating #43
Closed
els0r
els0r approved these changes May 20, 2023
View reviewed changes
Copy link
Collaborator

@els0r els0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@fako1024 fako1024 merged commit 81fb5b4 into main May 21, 2023
@fako1024 fako1024 deleted the 43-make-afring-capture-zero-allocating branch May 21, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@els0r els0r els0r approved these changes

Assignees

@fako1024 fako1024

Labels
performance Performance / optimization related topics
Projects
None yet
Milestone
Initial Release (v1)
Development

Successfully merging this pull request may close these issues.

Make afring capture zero-allocating
2 participants
@fako1024 @els0r