[trivial] Refactor / cleanup some code parts #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fako1024
added
enhancement
Closed
fako1024
commented
May 22, 2023
| @@ -231,3 +176,41 @@ func blockSizeTPacketAlign(x, blockSize int) (int, error) { | |||
|
|
|||
| return 0, fmt.Errorf("no valid frame size found for capture length %d / block size %d", x, blockSize) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I've moved all currently unused methods down here and commented them (might be that we use some of them in the future, and looking up the required struct positions can be tedious, so I hope keeping commented code is acceptable in this situation...
|
@els0r Trivial refactor / cleanup, feel free to approve at your convenience. TY! |
|
@els0r Friendly ping... 🙏 |
els0r
approved these changes
May 24, 2023
|
I keep missing the slimcap stuff. Sry |
No worries, thanks man! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45