[feature] Remove zap logging dependency in favor of log/slog #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fako1024
commented
Sep 4, 2023
fako1024
commented
Sep 4, 2023
… drop loopback duplicates
4 tasks
els0r
approved these changes
Sep 4, 2023
|
The action failures have nothing to do with the changes, it fails setting up the action environment. I assume it's some temporary issue with the GitHub runners (or the pipelines), will retry later... |
…k-interfaces [bugfix][feature] Provide packet type filtering capabilities for links / interfaces and drop loopback duplicates
fako1024
deleted the
64-remove-zap-logging-dependency-in-favor-of-logslog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the external package dependency. It is a tiny bit crude (in the sense that it requires some wrappers around the basic
log/slogfunctionality which would better be served by a proper implementation (e.g. the existing logging subpackage in github.com/els0r/goProbe). This should be tackled in a future issue though.Closes #64