Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(ci): added gha support. #311

Merged
merged 8 commits into from
Dec 18, 2023
Merged

new(ci): added gha support. #311

merged 8 commits into from
Dec 18, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Dec 15, 2023 •
edited
Loading

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #292

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(ci): ported CI to gha

@poiana poiana added kind/feature New feature or request dco-signoff: yes area/build Further information is requested labels Dec 15, 2023
@poiana poiana requested review from dwindsor and Lowaiz December 15, 2023 08:41
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 15, 2023

/hold

@FedeDP FedeDP force-pushed the new/gha branch 3 times, most recently from 69a4232 to 5e15da9 Compare December 15, 2023 08:45
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 15, 2023

/hold for now; when CI will be green, i will drop circleci jobs.

@FedeDP
new(ci): added gha support.
6e9c794 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
chore: disable builmode pie.
ef0efaf 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 15, 2023

I disabled buildmode pie and tested that:

  • i could run driverkit-amd64 on my machine
  • i could run driverkit-amd64 inside an ubuntu:18.04 docker container
  • i could run driverkit-amd64 inside an alpine:latest docker container
  • i could run driverkit-arm64 on an ubuntu-aws ec2 arm64 instance
  • i could run driverkit-arm64 inside an arm64 ubuntu:18.04 docker container
  • i could run driverkit-arm64 inside an arm64 alpine:latest docker container

@FedeDP
chore(ci): we can build on ubuntu-latest instead of alpine.
9d8e3b0 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
cleanup(ci): dropped circleci.
1b8f768 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana poiana added size/XXL and removed size/XL labels Dec 15, 2023
FedeDP
FedeDP commented Dec 15, 2023
View reviewed changes
.github/workflows/ci.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already tested on the pull request CI.

@FedeDP
chore(ci): moved manifest step to its own reusable workflow.
65db5b7 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
chore(ci): use matrixes where needed.
891febe 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
FedeDP commented Dec 15, 2023
View reviewed changes
.github/workflows/master.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master CI builds driverkit, push non-latest images and creates manifest to create multi arch docker image.

FedeDP
FedeDP commented Dec 15, 2023
View reviewed changes
.github/workflows/release.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release CI builds driverkit, push non-latest images and creates manifest to create multi arch docker image; finally, runs goreleaser to create the actual github release and attach release artifacts.

@FedeDP
chore(ci): better names.
3d4bac1 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
leogr
leogr previously approved these changes Dec 18, 2023
View reviewed changes
@poiana poiana added the lgtm label Dec 18, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 18, 2023

/cc @dwindsor @EXONER4TED

If this is ok for you, i can update required checks on test-infra and we can move on with this!

@poiana poiana requested a review from EXONER4TED December 18, 2023 09:42
EXONER4TED
EXONER4TED previously approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@EXONER4TED EXONER4TED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Very nice 😊

@FedeDP FedeDP mentioned this pull request Dec 18, 2023
Merged
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 18, 2023

Opened test-infra pr: falcosecurity/test-infra#1329

@FedeDP
fix(ci): fixed needs name in master and release CI.
98d8ed7 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP dismissed stale reviews from EXONER4TED and leogr via 98d8ed7 December 18, 2023 13:00
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 18, 2023

@EXONER4TED pushed a small fix :D

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 18, 2023

/unhold

@poiana
Copy link

poiana commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EXONER4TED, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 0a76376 into master Dec 18, 2023
5 checks passed
@poiana poiana deleted the new/gha branch December 18, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EXONER4TED EXONER4TED EXONER4TED approved these changes

@leogr leogr leogr left review comments

@dwindsor dwindsor Awaiting requested review from dwindsor

@Lowaiz Lowaiz Awaiting requested review from Lowaiz

Assignees

@leogr leogr

@EXONER4TED EXONER4TED

Labels
approved area/build Further information is requested dco-signoff: yes kind/feature New feature or request lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abandon CircleCI in favor of github actions
4 participants
@FedeDP @poiana @leogr @EXONER4TED