fix(pkg/driverbuilder): fixed local cmd build up using os.Environ(). #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moreover, properly mount debugfs before attempting the bpf probe build if needed. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
commented
Feb 14, 2024
| @@ -59,6 +59,12 @@ modinfo {{ .ModuleFullPath }} | |||
|
|
|||
| {{ if .BuildProbe }} | |||
| echo "* Building eBPF probe" | |||
|
|
|||
| if [ ! -d /sys/kernel/debug/tracing ]; then | |||
There was a problem hiding this comment.
If needed, mount debugfs before locally building the probe.
FedeDP
commented
Feb 14, 2024
| @@ -128,6 +128,7 @@ func (lbp *LocalBuildProcessor) Start(b *builder.Build) error { | |||
| ctx, cancelFunc := context.WithTimeout(context.Background(), time.Duration(lbp.timeout)*time.Second) | |||
| defer cancelFunc() | |||
| cmd := exec.CommandContext(ctx, "/bin/bash", "-c", driverkitScript) | |||
| cmd.Env = os.Environ() | |||
There was a problem hiding this comment.
If cmd.Env is not empty when running the cmd, it won't get auto-filled with Environ. Force fill before appending our env map.
4 tasks
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EXONER4TED, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area pkg
What this PR does / why we need it:
Moreover, properly mount debugfs before attempting the bpf probe build if needed.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: