rules update(Change thread namespace and Set Setuid or Setgid bit): d… #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaizhe
force-pushed
the
kh-disable_nosiy_rules
branch
from
4b429c2
to
f9d2182
Compare
mstemm
previously approved these changes
May 18, 2021
|
LGTM label has been added. Git tree hash: feaba8d90ba24d8788b34e5735f015c36522403b
|
|
@mstemm , did I miss anything on changing the test side? |
Hey @Kaizhe it seems to me that a few integration tests are expecting those rules to be enabled. |
…isable by default Signed-off-by: Kaizhe Huang <derek0405@gmail.com>
Signed-off-by: Kaizhe Huang <derek0405@gmail.com>
Signed-off-by: Kaizhe Huang <derek0405@gmail.com>
Signed-off-by: Kaizhe Huang <khuang@aurora.tech>
Kaizhe
force-pushed
the
kh-disable_nosiy_rules
branch
from
464096f
to
c1c84e2
Compare
fntlnz
approved these changes
Jun 6, 2021
|
LGTM label has been added. Git tree hash: af71311812c34342ef8c984b231002d7a8d71329
|
leodido
approved these changes
Jun 6, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…isable by default
Signed-off-by: Kaizhe Huang derek0405@gmail.com
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
The falco rules
Change thread namespaceandSet Setuid or Setgid bitare known to be noisy. Disable these two rules by default.Which issue(s) this PR fixes:
Reduce FP.
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: