-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): don't write to source directory during build #1034
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnosek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The fix is completely reasonable! The bpf probe compilation seems broken because we still search this file into the source dir |
@gnosek can you fix this? |
/milestone 0.12.0 |
Could be moved to 0.11.0 if Grzeg's response is quick :D |
Could we revamp this? 🤔 |
Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
TODO for me: double check that this does not break driverkit builds. |
Well, for #1452 i wrote a patch for driverkit to let it build through CMake: falcosecurity/driverkit#302 |
Same goes for #1188 ! |
Thanks for providing an update @FedeDP 🙏 |
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
/remove-lifecycle stale Hey @gnosek any update on this? 🤔 |
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
/remove-lifecycle stale Can we rebase this? |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
/area libscap-engine-bpf
/area libscap-engine-modern-bpf
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This patch makes it possible to build the libs from a read-only directory (like in a container).
Special notes for your reviewer:
Does this PR introduce a user-facing change?: