chore(driver): allow kmod and bpf drivers different components #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… install. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
…ike we do for kmod. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
|
/milestone 0.15.0 |
|
Please double check driver/API_VERSION file. See versioning. /hold |
Need to fix EDIT: ouch of course because it needs falcosecurity/driverkit#302 |
|
Driverkit 0.17.0 was released, and driverkit related tests now pass fine. |
leogr
approved these changes
Feb 29, 2024
|
/unhold |
|
/cc @jasondellaluce |
jasondellaluce
approved these changes
Mar 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
/area driver-kmod
/area driver-bpf
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR has a main scope: allow to install kmod and bpf under different components.
Also, now the ebpf probe gets built under
CMAKE_CURRENT_BINARY_DIRinstead ofCMAKE_CURRENT_SOURCE_DIR, in a similar way to kmod.Moreover, to properly build the bpf probe, all the
driver/*.hheader files are copied underCMAKE_CURRENT_BINARY_DIRfor bpf and get eventually installed when issuingmake install.It has the main advantage that in the future we might want to split up
falco-kmodandfalco-bpfpackages, BUT still retain the possibility to build the bpf probe under/usr/src/driverversion/bpf/folder.An example of the aforementioned issue is the current behavior if we configure libs using:
and then
make installit. Under/usr/src/$version/we will just have abpffolder, and if we move under it, we cannot build the bpf probe because its sources include headers from the parent (that was not installed).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: