Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed output issues within the ruleset #253

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

darryk10
Copy link
Contributor

@darryk10 darryk10 commented Jun 6, 2024

What type of PR is this?
PR to fix some output issues within the ruleset

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Stefano Chierici <stefano.chierici@sysdig.com>

Signed-off-by: schie <77834235+darryk10@users.noreply.github.com>
Copy link

github-actions bot commented Jun 6, 2024

Rules files suggestions

falco_rules.yaml

Comparing c918b9e70aa0711fb6e87212ca5e228ebf6a7617 with latest tag falco-rules-3.1.0

Patch changes:

  • Rule Contact K8S API Server From Container changed its output fields
  • Rule Packet socket created in container changed its output fields
  • Rule Redirect STDOUT/STDIN to Network Connection in Container changed its output fields
  • Rule Disallowed SSH Connection Non Standard Port changed its output fields

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks!

@poiana
Copy link

poiana commented Jun 6, 2024

LGTM label has been added.

Git tree hash: 9d970af7688575944bf54cf744dba608809f4b5a

@poiana
Copy link

poiana commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darryk10, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit ea57e78 into main Jun 6, 2024
8 of 9 checks passed
@poiana poiana deleted the darryk10-patch-1 branch June 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants