-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(incubating_rules): revert #508 #257
Conversation
Rules files suggestionsfalco-incubating_rules.yamlComparing Patch changes:
|
LGTM label has been added. Git tree hash: 70cc2fad124907902448783fa9a806dc51f084bf
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
ohhh, ty!
/hold |
@LucaGuerra mind also updating the description? |
Rules files suggestionsfalco-incubating_rules.yamlComparing Patch changes:
|
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
e21150f
to
250a993
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/unhold
LGTM label has been added. Git tree hash: 4a03117c5fb4a724568384a70987799fb08cec5a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: incertum, loresuso, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rules files suggestionsfalco-incubating_rules.yamlComparing Patch changes:
|
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area rules
Proposed rule maturity level
/area maturity-incubating
What this PR does / why we need it:
In #208 we changed the type of the
cmd
argument to a flag type because of changes in falcosecurity/libs#1545 , however the libs PR was only modifying the exit event, while this rule refers to the enter event which is still an INT64, thus we still need to use the value5
for this event. I noticed this during a conversation with @incertum .Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: