Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

Add update endpoint method #171

Closed
wants to merge 6 commits into from
Closed

Add update endpoint method #171

wants to merge 6 commits into from

Conversation

zacho112
Copy link

Added update endpoint method.

But for some reason ISE won't allow to change the name of an ERSEndpoint, but I left it in the update method, just as it's in the add method.

Tested on ISE:

Version: 2.6.0.156
Installed Patches: 5,7

@zacho112 zacho112 marked this pull request as ready for review July 29, 2021 08:19
@falkowich
Copy link
Owner

falkowich commented Sep 30, 2021

I will check this out as soon as #164 is done

And I am sorry for taking so much time with this..

--
Regards Falk

@falkowich falkowich added this to the 0.2.0 milestone Sep 30, 2021
falkowich added a commit that referenced this pull request Oct 2, 2021
@falkowich
Copy link
Owner

falkowich commented Oct 2, 2021

Hi,

I have manually implemented the changes since i made the namechange first.. (smart move by me...)
Here in this branch » https://github.com/falkowich/pyise-ers/tree/zacho112-pr

But I wonder if this is by default, or this is a bug?
When you do an update on an endpoint, are we still requiring both mac and group_id?

Thougts?

--
Regards Falk

@E-ThanG
Copy link

E-ThanG commented Oct 22, 2021

I'm not sure if it's a good idea to have non-empty default arguments for static_profile_assignment and static_group_assignment. What happens if you update an endpoint that doesn't have a static group? Would it statically assign "Unknown"?

I made my own update method and have a default empty string for those attributes. That way I can check if there is an update for them and react. I was also considering not allowing those attributes as an argument and only setting them if the profile_id or group_id arguments are passed since one without the other is meaningless.

Also, confirming the same behavior with the name attribute. It doesn't honor updates, they are just ignored.

@E-ThanG
Copy link

E-ThanG commented Oct 27, 2021

TAC confirmed that the endpoint "name" attribute must be the MAC address and it cannot be altered. The observed behavior is as designed.

@ChilloManiac
Copy link

Bump

@falkowich
Copy link
Owner

Any more information on this, I'm trying to clean up some PR's before 0.3.
So if someone have more information on this I'm all ears :)

@falkowich
Copy link
Owner

Closing this.
If it's still up for merge, please renew the PR.

Really sorry for the trouble.

@falkowich falkowich closed this May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants