Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Mutex.new to constructor #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olleolleolle
Copy link

This PR moves the Mutex creation to the constructor of this class.

  • You could end up with more than one mutex on platforms wihtout a GIL/GVL

Hope this helps!

@olleolleolle
Copy link
Author

cc @ioquatix

lib/carrot/amqp/server.rb Outdated Show resolved Hide resolved
  - Make the check for multi-processing "Do we have a Mutex?" by using
  safe navigation
  - We do this change because we could end up with more than one Mutex
  on platforms without a GIL/GVL, such as JRuby
@olleolleolle olleolleolle force-pushed the avoid-lazy-init-of-mutex branch from c7bf66d to 6e74e32 Compare April 4, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants