refactor: code organization #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.82% // Head: 91.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 90.82% 91.06% +0.24%
==========================================
Files 40 41 +1
Lines 2180 2172 -8
Branches 370 372 +2
==========================================
- Hits 1980 1978 -2
+ Misses 188 183 -5
+ Partials 12 11 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
varunsrin
commented
Oct 10, 2022
| @@ -12,7 +12,7 @@ module.exports = { | |||
| '@typescript-eslint/ban-ts-ignore': 'off', | |||
| '@typescript-eslint/explicit-function-return-type': 'off', | |||
| '@typescript-eslint/no-explicit-any': 'off', | |||
| 'no-restricted-imports': ['error', { patterns: ['.*'] }], | |||
| 'no-restricted-imports': ['error', { patterns: ['"*/lib/*"'] }], | |||
There was a problem hiding this comment.
note to self: should be build not lib
sagar-a16z
approved these changes
Oct 10, 2022
2 tasks
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Hub has become more complicated and harder to reason about as the size of the codebase as grown. A high level design that we all agree on will make it much easier to read and write code as we are getting ready for the first release.
Change Summary
The PR is very large, touches many files and squeezed in all the changes I could over a single weekend to reduce merge conflicts during the workweek. A series of smaller followup changes will be made over the next week to bring the rest in line. Comments and suggestions are welcome for other things that should be updated, or patterns that people disagree with.
The major changes are:
network,storage,types,utilsandurlsrpcinto a module, which is a pattern we should replicate over the codebase to keep files smalltestfolderhubs.tsMerge Checklist
Additional Context
If this is a relatively large or complex change, provide more details here that will help reviewers