Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds EIP1271 to supported signature type #176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

parseb
Copy link

@parseb parseb commented May 25, 2024

Adds EIP1271 signature type to signer registry graph

Adds EIP1271 signature type to signer registry graph
@parseb
Copy link
Author

parseb commented May 25, 2024

What is the bug?

protocolBug

The Specification mentions only ECDSA signature support for managing signers.
The validator calls the registry's verifyFidSignature which makes use of OpenZeppelin's SignatureChecker util which supports EIP1271 signature.
As such, the signature is validated by the issuing smart contract and not by ECDSA recovery.

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/e50c24f5839db17f46991478384bfda14acfb830/contracts/utils/cryptography/SignatureChecker.sol#L43

How can it be reproduced? (optional)
Include steps, code samples, replits, screenshots and anything else that would be helpful to reproduce the problem.

Additional context (optional)
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant