Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: style on selected range #92

Merged

Conversation

zdinidz
Copy link
Contributor

@zdinidz zdinidz commented Jun 3, 2024

i wanna fix bug on styling selected date range
from this
image

to this
image

@zdinidz
Copy link
Contributor Author

zdinidz commented Jun 3, 2024

i add condition for selected range with single and same day

from this
image

to be this
image

@Yzzzed
Copy link

Yzzzed commented Sep 5, 2024

same problem. Hope it can be fixed soon.

@gtarnowski
Copy link

any chance to merge it :) ?

@zdinidz
Copy link
Contributor Author

zdinidz commented Sep 10, 2024

any chance to merge it :) ?

i think yes, how to merge it?

@jtsimoes
Copy link

LGTM!
However, there is still a related issue with the selected range when displayFullDays = true:

Start date is in the previous month End date is in the next month Start date is in the previous month and end date is in the next month Start date and end date are in the current month
bug_2 bug_3 bug_1 bug_4

Any idea how to fix it? If so, wouldn't be a good idea to include it in this PR too?

@zdinidz
Copy link
Contributor Author

zdinidz commented Sep 13, 2024

image
image
image
i have fix it but i haven't push it

@farhoudshapouran farhoudshapouran merged commit be9df59 into farhoudshapouran:main Sep 15, 2024
2 of 3 checks passed
@Yzzzed
Copy link

Yzzzed commented Sep 27, 2024

LGTM! However, there is still a related issue with the selected range when displayFullDays = true:

Start date is in the previous month End date is in the next month Start date is in the previous month and end date is in the next month Start date and end date are in the current month
bug_2 bug_3 bug_1 bug_4
❌ ❌ ❌ ✅
Any idea how to fix it? If so, wouldn't be a good idea to include it in this PR too?

i have fixed it and created a new pr. #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants