Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transitioning for PR events #2

Merged
merged 5 commits into from
Jun 29, 2020
Merged

Add transitioning for PR events #2

merged 5 commits into from
Jun 29, 2020

Conversation

kuritz
Copy link
Member

@kuritz kuritz commented Jun 29, 2020

Context

It's been requested to transition stories in response to certain pull_request events.

Analysis

All of the basic pieces already exist to do this. Its a slightly different/smaller number of steps to just transition a story, so at least for now, can live with a bit of duplication and simply split all non-release-cases to a diff entrypoint to the clubhouse module.

Solution

  • Added transitionStories to handle non-releases
  • Updated the action's run entrypoint to conditionally invoke ch depending on the event
  • Added test for extracting story ID from PR Title
  • Updated README
  • Repackaged

Testing

Ran on the testing repo:
https://github.com/farmersdog/clubhouse-action-test/pull/1/checks?check_run_id=814832485

@kuritz kuritz self-assigned this Jun 29, 2020
@kuritz kuritz requested a review from dillonjason June 29, 2020 13:16
@kuritz kuritz changed the title Add tranistioning for PR events Add transitioning for PR events Jun 29, 2020
dillonjason
dillonjason previously approved these changes Jun 29, 2020
Copy link

@dillonjason dillonjason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if you should use the branch name instead of the PR title?

@kuritz
Copy link
Member Author

kuritz commented Jun 29, 2020

Yeah that would make sense too. Did the title on the assumption that we would have that other piece that automatically places the tag in the PR title, if a story id exists in the branch name. But i think it would be easy to add a toggle to this to make it configurable.

@kuritz
Copy link
Member Author

kuritz commented Jun 29, 2020

dismissed dillonjason’s stale review via 25e3228 1 hour ago

^ this is new, interesting.

anyway, i updated it to take the branch, title, and body and combine them to find all stories in any of them, and then deduplicate as part of the extraction process. so we can use the branch or the title or both and it shouldn't matter.

@kuritz kuritz requested a review from dillonjason June 29, 2020 16:28
@kuritz kuritz merged commit 48a3fe1 into master Jun 29, 2020
@kuritz kuritz deleted the add-pull-request branch June 29, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants