Add Harness source and Faros destination's converter #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjwooo
reviewed
Nov 9, 2021
| "account_id": { | ||
| "type": "string", | ||
| "title": "Harness account ID", | ||
| "airbyte_secret": true |
There was a problem hiding this comment.
Does the account id need to be secret?
There was a problem hiding this comment.
Account id can be public. I'll change it to not be a secret
|
Is there a test Harness server we can spin up to test, similar to how we do Jenkins, or do we need to test against a live Harness account? |
cjwooo
reviewed
Nov 9, 2021
| execution: HarnessExecutionNode, | ||
| source: string | ||
| ): | ||
| | { |
There was a problem hiding this comment.
This seems pretty clunky read. Can you make the non-undefined return type a local interface?
There was a problem hiding this comment.
Ok. I've created interface
|
Harness has [delegate](The Harness Delegate is a service). It's service but not Harness's local instance |
cjwooo
approved these changes
Nov 16, 2021
|
Yay! Please update README |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Related issues
Migration notes
Extra info