Skip to content

Commit

Permalink
Fixed and improved album and artists link from songs context menu #3718
Browse files Browse the repository at this point in the history
  • Loading branch information
fast4x committed Oct 4, 2024
1 parent 0735442 commit 9731c8e
Showing 1 changed file with 15 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,8 @@ fun NonQueuedMediaItemMenu(
MenuStyle.List
)

//println("mediaItem in NonQueuedMediaItemMenu albumId ${mediaItem.mediaMetadata.extras?.getString("albumId")}")

if (menuStyle == MenuStyle.Grid) {
BaseMediaItemGridMenu(
navController = navController,
Expand Down Expand Up @@ -475,7 +477,7 @@ fun BaseMediaItemMenu(
val isPipedEnabled by rememberPreference(isPipedEnabledKey, false)
val pipedSession = getPipedSession()


//println("mediaItem in BaseMediaItemMenu albumId ${mediaItem.mediaMetadata.extras?.getString("albumId")}")

MediaItemMenu(
navController = navController,
Expand Down Expand Up @@ -522,7 +524,7 @@ fun BaseMediaItemMenu(
if (onClosePlayer != null) {
onClosePlayer()
}
}, //albumRoute::global,
},
onGoToArtist = {
navController.navigate(route = "${NavRoutes.artist.name}/${it}")
if (onClosePlayer != null) {
Expand Down Expand Up @@ -705,13 +707,17 @@ fun MediaItemMenu(
mutableStateOf(0.dp)
}

//println("mediaItem in MediaItemMenu albumId ${mediaItem.mediaMetadata.extras?.getString("albumId")}")


var albumInfo by remember {
mutableStateOf(mediaItem.mediaMetadata.extras?.getString("albumId")?.let { albumId ->
Info(albumId, null)
})
}

//println("mediaItem in MediaItemMenu albumInfo albumId ${albumInfo?.id}")

var artistsInfo by remember {
mutableStateOf(
mediaItem.mediaMetadata.extras?.getStringArrayList("artistNames")?.let { artistNames ->
Expand Down Expand Up @@ -740,10 +746,10 @@ fun MediaItemMenu(

LaunchedEffect(Unit, mediaItem.mediaId) {
withContext(Dispatchers.IO) {
//if (albumInfo == null)
albumInfo = Database.songAlbumInfo(mediaItem.mediaId)
//if (artistsInfo == null)
artistsInfo = Database.songArtistInfo(mediaItem.mediaId)
if (albumInfo?.id.isNullOrEmpty())
albumInfo = Database.songAlbumInfo(mediaItem.mediaId)
if (artistsInfo.isNullOrEmpty())
artistsInfo = Database.songArtistInfo(mediaItem.mediaId)

artistsInfo?.forEach { info ->
if (info.id.isNotEmpty()) artistIds.add(info.id)
Expand Down Expand Up @@ -1441,6 +1447,9 @@ fun MediaItemMenu(
}
*/

//println("mediaItem in MediaItemMenu onGoToAlbum ALBUMiD ${mediaItem.mediaMetadata.extras?.getString("albumId")}")
//println("mediaItem in MediaItemMenu onGoToAlbum albumInfo ${albumInfo?.id}")

if (!isLocal) onGoToAlbum?.let { onGoToAlbum ->
albumInfo?.let { (albumId) ->
MenuEntry(
Expand Down

0 comments on commit 9731c8e

Please sign in to comment.