-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App crashes #1052
Comments
After some debugging, I found that downloadCache is a global object and should not be released when PlayerService is destroyed.
RiMusic/app/src/main/kotlin/it/vfsfitvnm/vimusic/service/DownloadUtil.kt Lines 295 to 307 in 4199326
So the easiest fix for Crash1 is to remove this line
|
Crash2 related:
RiMusic/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/screens/player/Queue.kt Lines 215 to 216 in 39fb2d0
RiMusic/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/screens/player/Queue.kt Lines 221 to 222 in 39fb2d0
The -1 is the key point, I'm guessing it can be fixed by just changing it to player.currentMediaItemIndex .
|
Hello I made the changes you indicated, thank you for the time you devoted and for the fix of the problem. I put your name in the project’s contributor developers. In the next release you will actually see if the problem resolves. Thanks again. Available from version 0.6.26 |
Steps to reproduce the bug
Crash 1: A song fails to play after a while
Crash 2: When opening the playlist
Expected behavior
Not Crash
Actual behavior
Crashed
Screenshots/Screen recordings
No response
Logs
Crash:1
Crash2:
RiMusic version
0.6.25
Android version
Android 14
Additional information
Crash1 looks related #982
The text was updated successfully, but these errors were encountered: