Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Background Progress Bar in Mini Player #1117

Closed
NikunjKhangwal opened this issue Mar 17, 2024 · 18 comments
Closed

[Feature]: Background Progress Bar in Mini Player #1117

NikunjKhangwal opened this issue Mar 17, 2024 · 18 comments
Labels
enhancement New feature or request implemented Feature or request have been developed

Comments

@NikunjKhangwal
Copy link

Description

This request actually came from a different ViMusic fork called ViTune. It has a background progress bar in mini player which looks pretty clean. Since it's also in Kotlin, you might be able to use it as reference.

Suggested Solution

This is how it looks like in ViTune:-
IMG_20240318_010000
It also goes under device navigation bar which is something i don't like

So here's my concept
Picsart_24-03-18_00-12-58-602
Also it'll not create any overlapping problem if bottom navigation bar gets implement in RiMusic in future.

Alternatives

No response

Additional Context

No response

@NikunjKhangwal NikunjKhangwal added the enhancement New feature or request label Mar 17, 2024
@OrangeZXZ
Copy link

I would love if it looked like on ViTune!
also the concept i dont like since that bottom bar is not filled as well

@NikunjKhangwal
Copy link
Author

I would love if it looked like on ViTune! also the concept i dont like since that bottom bar is not filled as well

Let see what fast4x prefer

@Vishcot
Copy link

Vishcot commented Mar 20, 2024

Would seriously look so satisfying! @fast4x what do you think about it?

@fast4x
Copy link
Owner

fast4x commented Mar 20, 2024

I think it’s a nice idea

@Vishcot
Copy link

Vishcot commented Mar 20, 2024

I think it’s a nice idea

Would love to see this, if its possible to implement 😀

@fast4x
Copy link
Owner

fast4x commented Mar 20, 2024

Implemented, available from version 0.6.27

@fast4x fast4x added the implemented Feature or request have been developed label Mar 20, 2024
@NikunjKhangwal
Copy link
Author

It still blows my mind how talented you are. I've never seen any other developer implementing whole new features and fixing bugs this quickly. You understand the source code of your project way too well.

@fast4x
Copy link
Owner

fast4x commented Mar 20, 2024

It still blows my mind how talented you are. I've never seen any other developer implementing whole new features and fixing bugs this quickly. You understand the source code of your project way too well.

Thank you, I can tell you that I study the code trying to find the best solution as quickly as possible at that time.
Thank you

@fast4x
Copy link
Owner

fast4x commented Mar 22, 2024

Implemented background progress bar also in player page, enable/disable by player appearance settings.
Available from version 0.6.27

@OrangeZXZ
Copy link

Implemented background progress bar also in player page, enable/disable by player appearance settings.
Available from version 0.6.27

what do you mean on player page? the background or the bottom bar?

@sayyid5416
Copy link

Implemented background progress bar also in player page, enable/disable by player appearance settings.
Available from version 0.6.27

what do you mean on player page? the background or the bottom bar?

in app settings

@fast4x
Copy link
Owner

fast4x commented Mar 22, 2024

Implemented background progress bar also in player page, enable/disable by player appearance settings.
Available from version 0.6.27

what do you mean on player page? the background or the bottom bar?

Screenrecorder-2024-03-22-13-49-34-567.mp4

this... enable/disable in player appearance settings...

@OrangeZXZ
Copy link

Implemented background progress bar also in player page, enable/disable by player appearance settings.
Available from version 0.6.27

what do you mean on player page? the background or the bottom bar?

Screenrecorder-2024-03-22-13-49-34-567.mp4

this... enable/disable in player appearance settings...

that looks cool but I think it could be a bit changed it the next update il do a issue after testing it also could you move the speed at the Top or bottom of the button maybe outside of it too if the dosen't bother you because it feels weird where it is actualy

@fast4x
Copy link
Owner

fast4x commented Mar 22, 2024

Yes no problem

@NikunjKhangwal
Copy link
Author

Personally not a fan of it but I'm glad there's a option to disable it. I only want it in mini player

@OrangeZXZ
Copy link

Personally not a fan of it but I'm glad there's a option to disable it. I only want it in mini player

yeah showing in miniplayer could be nice too but then you need to close the player to see it

@fast4x
Copy link
Owner

fast4x commented Mar 22, 2024

Of course it is a possibility, in the future it can also be a beautiful innovative idea

@NikunjKhangwal
Copy link
Author

yeah showing in miniplayer could be nice too but then you need to close the player to see it

That's what i wanted honestly and that's how it works in ViTune. It's just a cool visual feature. Showing mini player on main player would make it cluttered and i can't think of any other idea. But as fast4x said this feature could evolve later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implemented Feature or request have been developed
Projects
None yet
Development

No branches or pull requests

5 participants