Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Position of settings in bottom bar #1389

Closed
4 tasks done
sayyid5416 opened this issue Apr 6, 2024 · 11 comments
Closed
4 tasks done

[Feature]: Position of settings in bottom bar #1389

sayyid5416 opened this issue Apr 6, 2024 · 11 comments
Labels
enhancement New feature or request Idea New idea ti be explored implemented Feature or request have been developed

Comments

@sayyid5416
Copy link

sayyid5416 commented Apr 6, 2024

Description

These buttons should be positioned in top-left corner of the app when using bottom navigation bar:

  • Settings button, and
  • back button

Benefits:

  • Less cluttered navigation bar.
  • Top icons and label would look more symmetric.

Additional info:

  • Also move the back button from the Albums page to the top-left corner to make it more consistent.
  • Since back button will be moved to top-left corner, Playlists will have only one icon i.e songs icon. Remove it, because it's not really necessary.
@dAtA-TRoN
Copy link

Nice!

@dAtA-TRoN
Copy link

dAtA-TRoN commented Apr 6, 2024

IMG_20240406_141324_098.jpg

The stats icon have now moved to the top left corner on the library page due to the new update. However, if we want consistency with the settings icon, the stats icon should probably be moved elsewhere. I suggest giving it it's own prominent place in the library. This would also fill the ugly empty space and create a more uniform appearance. What do you think of the suggestion?

Additionally, it's important to address the formatting across the app as a whole. Each submenu seems to have its own rules in this regard.

@sayyid5416
Copy link
Author

sayyid5416 commented Apr 6, 2024

No, I don't agree with stats and search icon.

  • Best place for search icon is in top-right corner, and
  • Current location of stats icon feels natural.

Additionally:

  • Search icon at top-right corner and back/settings icon at top-left corner will align the top heading properly.

Note:

  • Btw, when I meant to put settings and back button in top-left corner, I meant opposite to current search icon, and not where you have shown.

@dAtA-TRoN
Copy link

dAtA-TRoN commented Apr 6, 2024

Oh now I see. Thanks for clarifying this.
I agree with that.

However, I have a different perspective on the stats icon. First, stats are essentially a set of playlists, so it would be logical to include it with the other playlists. Secondly, there's enough space to highlight this great feature more prominently, so why shouldn't we take advantage of it. Additionally, it would create a cohesive look for the entire library page.

@sayyid5416
Copy link
Author

sayyid5416 commented Apr 6, 2024

Reasons we should not show stats as a special playlist like downloaded, cached, or My Top:

  • All those special playlists essentially acts like one folder, while stats contains many more folders inside like today, weekly, monthly etc.
  • Opening those special playlist shows same type of navigation bar, while stats shows different types of items in navigation bar.
  • You can switch among those special playlists directly after opening anyone of them. If stats icon is added as special playlist, it would create problem for this.
  • Current location for stats seems natural.

@sayyid5416
Copy link
Author

Btw I've created another request regarding improper spacings/margins #1391

@dAtA-TRoN
Copy link

dAtA-TRoN commented Apr 6, 2024

All good and valid points you're making there, however, it's easy to circumvent them by simply demarcating the button of the stats with different colors like this (it's just an example, I'm no artist):

sketch1712418875274.png

But don't worry, that's not the hill I want to die on.

@sayyid5416
Copy link
Author

If you think this is a good idea, you should create a different issue, otherwise fast4x might get confused what this request is about and what's being discussed.

Although I don't personally like this idea of having stats in special playlist, but if you think it's a good idea, it's atleast worth discussing

@dAtA-TRoN
Copy link

If you think this is a good idea, you should create a different issue, otherwise fast4x might get confused what this request is about and what's being discussed.

Although I don't personally like this idea of having stats in special playlist, but if you think it's a good idea, it's atleast worth discussing

No, it's not that important to me. The current implementation is completely okay as it is.

@sayyid5416
Copy link
Author

back button and settings button implemented in #1513. Only last task remained, @fast4x Can you look at it?

@fast4x fast4x added the implemented Feature or request have been developed label Apr 16, 2024
@fast4x
Copy link
Owner

fast4x commented Apr 16, 2024

Implemented, available from version 0.6.31

fast4x added a commit that referenced this issue Apr 19, 2024
@fast4x fast4x closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Idea New idea ti be explored implemented Feature or request have been developed
Projects
None yet
Development

No branches or pull requests

3 participants