Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant Buttons in Player View after changing Controls Type #2034

Closed
dAtA-TRoN opened this issue May 26, 2024 · 22 comments
Closed

Redundant Buttons in Player View after changing Controls Type #2034

dAtA-TRoN opened this issue May 26, 2024 · 22 comments
Labels
bug Something isn't working enhancement New feature or request Idea New idea ti be explored implemented Feature or request have been developed

Comments

@dAtA-TRoN
Copy link

dAtA-TRoN commented May 26, 2024

Steps to reproduce the bug

  1. Open RiMusic.

  2. Navigate to Settings > Player Appearance > Controls Type.

  3. Set the Controls Type to "Essential".

  4. Go to the Player View.

Expected behavior

The Player View should display only the essential controls without redundant extra buttons.

Actual behavior

The Player View shows redundant repeat and like buttons next to the play button.

Screenshots

Screenshot_2024-05-26-06-00-41-48_91b67804b5fb3353a77fb824d6bb0b50

Suggested Fix

Remove the redundant symbols on the left and right of the play button in the Player View and make the remaining player controls larger, same as > Controls Type > Modern.

RiMusic version

0.6.36.1

Android version

Android 13

@dAtA-TRoN dAtA-TRoN added the bug Something isn't working label May 26, 2024
@dAtA-TRoN dAtA-TRoN changed the title Extra Buttons in Player View Redundant Extra Buttons in Player View May 26, 2024
@dAtA-TRoN dAtA-TRoN changed the title Redundant Extra Buttons in Player View Redundant Buttons in Player View after changing Controls Type May 26, 2024
@aneesh1122
Copy link

aneesh1122 commented May 26, 2024

Those redundant buttons are a part of ViMusic Interface. If you switch to ViMusic mode you'll find no 'like' button next to the song's name.

Essential is basically ViMusic's buttons and Modern is Rimusic's buttons.

See #2018

@dAtA-TRoN
Copy link
Author

dAtA-TRoN commented May 26, 2024

Those redundant buttons are a part of ViMusic Interface. If you switch to ViMusic mode you'll find no 'like' button next to the song's name.

Essential is basically ViMusic's buttons and Modern is Rimusic's buttons.

See #2018

Thank you for clearing that up. But if you're in RiMusic Mode and using the 'Essential' Controls Type, those buttons lose their purpose. So, it'd be wise to consider the steps I suggested.

@aneesh1122
Copy link

Those redundant buttons are a part of ViMusic Interface. If you switch to ViMusic mode you'll find no 'like' button next to the song's name.

Essential is basically ViMusic's buttons and Modern is Rimusic's buttons.

See #2018

Thank you for clearing that up. But if you're in RiMusic Mode and using the 'Essential' Controls Type, those buttons lose their purpose. So, it'd be wise to consider the steps I suggested.

If you ask me, both RiMusic and ViMusic mode should have their own essential or modern controls.

@dAtA-TRoN
Copy link
Author

If you ask me, both RiMusic and ViMusic mode should have their own essential or modern controls.

Perfect solution!

@dAtA-TRoN
Copy link
Author

I even want that artist and song's icon to be removed or at least made an option in RiMusic mode but fast4x insists on using ViMusic mode if you don't want those icons.

I also think it would be better without the icons. It looks cleaner that way. If there's one thing I've learned about fast4x, it's that he's the last person you couldn't talk to again to change his mind if he sees any sense in it. Maybe we should both politely ask again. So, Mr. fast4x, if you're reading this (and I know you are), what do you think, huh!?

@aneesh1122
Copy link

aneesh1122 commented May 26, 2024

I even want that artist and song's icon to be removed or at least made an option in RiMusic mode but fast4x insists on using ViMusic mode if you don't want those icons.

I also think it would be better without the icons. It looks cleaner that way. If there's one thing I've learned about fast4x, it's that he's the last person you couldn't talk to again to change his mind if he sees any sense in it. Maybe we should both politely ask again. So, Mr. fast4x, if you're reading this (and I know you are), what do you think, huh!?

Forget about it. I've deleted my comment. I'll continue using ViMusic mode. I just hope he will add the missing heart icon

This is what I want to be universal in the app no matter what UI you choose.

  1. remove the artist and song icons
  2. put the song's and artist's name at centre
  3. make the song's name bolder and a little bigger than the artist's name.

@dAtA-TRoN
Copy link
Author

dAtA-TRoN commented May 26, 2024

Forget about it. I've deleted my comment. I'll continue using ViMusic mode. I just hope he will add the missing heart icon

This is what I want to be universal in the app no matter what UI you choose.

...and there you go again, barging right in. The previous solution was better because it didn't concern everyone. I can easily imagine you'll face pushback for your demands here, if not from other users, then perhaps from fast4x. You shouldn't always assume that your solution is the best.

I believe the best, albeit most demanding, solution would be a fully customizable editor (including a preview window) for the Player Page. This would allow users to mix and match elements to their liking. 'Modern' and 'Essential' modes could be easily selectable presets, along with a 'Custom' option. This way, everyone would be satisfied -except for fast4x, who has to program all this stuff 🤣.

@aneesh1122
Copy link

Forget about it. I've deleted my comment. I'll continue using ViMusic mode. I just hope he will add the missing heart icon\n\nThis is what I want to be universal in the app no matter what UI you choose.\n\nremove the artist and song icons\nput the song's and artist's name at centre\nmake the song's name bolder and a little bigger than the artist's name.

...and there you go again, barging right in. The previous solution was better because it didn't concern everyone. I can easily imagine you'll face pushback for your demands here, if not from other users, then perhaps from fast4x. You shouldn't always assume that your solution is the best. Others will probably be annoyed if the app changes too much without making these new adjustments optional.

Well, I said what I want. I know it won't be changed so that's why I spoke my mind. I don't want fast4x to make it universal.

If we are talking about options. Maybe this can be implemented

  1. toggle icons on/off
  2. change songs and the artist's name's position between left and centre.

What I request fast4x is to make it universal to have the song's name 'bold' and 'bigger'.

If people have problems with this then this can also be optional.

@aneesh1122
Copy link

I believe the best, albeit most demanding, solution would be a fully customizable editor (including a preview mode) for the Player Page. This would allow users to mix and match elements to their liking. 'Modern' and 'Essential' modes could be easily selectable presets, along with a 'Custom' option. This way, everyone would be satisfied—except for fast4x, who has to program all this stuff

Yeah this is good.

We get to choose icons, names' position, button and cover image shadows etc

@dAtA-TRoN
Copy link
Author

Yeah this is good.\n\nWe get to choose icons, names' position, button and cover image shadows etc

Just like in Nova Launcher. Do you know the app?

@aneesh1122
Copy link

Yeah this is good.\n\nWe get to choose icons, names' position, button and cover image shadows etc

Just like in Nova Launcher. Do you know the app?

Tried a long time ago. I like simple things so went back to the stock launcher.

@dAtA-TRoN
Copy link
Author

dAtA-TRoN commented May 26, 2024

Tried a long time ago. I like simple things so went back to the stock launcher.

I just wanted to talk about the editor views, because Nova Launcher does it exactly as I described: you have a large preview window, and below it you can adjust all sorts of settings and immediately see what changes. This is very cool and makes all these often cryptic settings very understandable, even for laypeople.

Possible settings for the RiMusic Player Page could include:

  • Icons on/off
  • Font size
  • Font type
  • Font color
  • Drop shadow on/off
  • Positioning of various elements

Additionally, all other existing settings could be incorporated into this editor as well.

@aneesh1122
Copy link

Tried a long time ago. I like simple things so went back to the stock launcher.

I just wanted to talk about the editor views, because Nova Launcher does it exactly as I described: you have a large preview window, and below it you can adjust all sorts of settings and immediately see what changes. This is very cool and makes all these often cryptic settings very understandable, even for laypeople.

Possible settings for the RiMusic Player Page could include:

  • Icons on/off
  • Font size
  • Font type
  • Font color
  • Drop shadow on/off
  • Positioning of various elements

Additionally, all other existing settings could be incorporated into this editor as well.

This seems too complicated to implement now.

Maybe we should focus on small things.

  1. I want the 'like' icon so that icon should be made a part of the modern controls.

  2. you want modern controls without shadows so you can ask for that.

@dAtA-TRoN
Copy link
Author

This seems too complicated to implement now.

That wasn't a demand; I was just thinking out loud.

@fast4x
Copy link
Owner

fast4x commented May 26, 2024

Great, I see with great pleasure that you are talking without fighting and I really like this.

For this and other reasons i want to make you happy and to thank you, I will begin to implement some basic functions that over time will allow you to improve and customize the controls of the player.

Patience, I will ask for help at fast6x to develop more quickly, but without caring eh...

If not, I’ll go completely crazy, at least for now I’m 30% crazy

🤣🤣🤣😂😂😂🤣🤣😂😂🤣🤣

@fast4x fast4x added Idea New idea ti be explored enhancement New feature or request labels May 26, 2024
@dAtA-TRoN
Copy link
Author

dAtA-TRoN commented May 26, 2024

30% crazy

...LIAR (110% at least) 😂😂😂!!!

But seriously (and I mean it!): don't overwork yourself with this stuff. Give yourself a break for a week or so where you don't do anything.

@aneesh1122
Copy link

aneesh1122 commented May 26, 2024

Great, I see with great pleasure that you are talking without fighting and I really like this.

For this and other reasons i want to make you happy and to thank you, I will begin to implement some basic functions that over time will allow you to improve and customize the controls of the player.

Patience, I will ask for help at fast6x to develop more quickly, but without caring eh...

If not, I’ll go completely crazy, at least for now I’m 30% crazy

🤣🤣🤣😂😂😂🤣🤣😂😂🤣🤣

Dude...I think we have awakened the true fast4x now.

Beast mode activated 😂😂

@dAtA-TRoN
Copy link
Author

@ aneesh1122

Yeah, he's like...

proxy-image(1).gif

@fast4x
Copy link
Owner

fast4x commented May 26, 2024

🤣🤣🤣🤣🤣🤣🤣🤣

@fast4x
Copy link
Owner

fast4x commented May 26, 2024

i.....
giphy (3).gif

@fast4x
Copy link
Owner

fast4x commented May 27, 2024

Implemented, controls and artist/album info in modern/essential type, can be used in both rimusic/vimusic mode.
So, can use how anyone want...
Available from version 0.6.37

@fast4x fast4x added the implemented Feature or request have been developed label May 27, 2024
@fast4x
Copy link
Owner

fast4x commented May 27, 2024

Other micro customizations for now isn't praticable...

@fast4x fast4x closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Idea New idea ti be explored implemented Feature or request have been developed
Projects
None yet
Development

No branches or pull requests

3 participants