-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redundant Buttons in Player View after changing Controls Type #2034
Comments
Those redundant buttons are a part of ViMusic Interface. If you switch to ViMusic mode you'll find no 'like' button next to the song's name. Essential is basically ViMusic's buttons and Modern is Rimusic's buttons. See #2018 |
Thank you for clearing that up. But if you're in RiMusic Mode and using the 'Essential' Controls Type, those buttons lose their purpose. So, it'd be wise to consider the steps I suggested. |
If you ask me, both RiMusic and ViMusic mode should have their own essential or modern controls. |
Perfect solution! |
I also think it would be better without the icons. It looks cleaner that way. If there's one thing I've learned about fast4x, it's that he's the last person you couldn't talk to again to change his mind if he sees any sense in it. Maybe we should both politely ask again. So, Mr. fast4x, if you're reading this (and I know you are), what do you think, huh!? |
Forget about it. I've deleted my comment. I'll continue using ViMusic mode. I just hope he will add the missing heart icon This is what I want to be universal in the app no matter what UI you choose.
|
...and there you go again, barging right in. The previous solution was better because it didn't concern everyone. I can easily imagine you'll face pushback for your demands here, if not from other users, then perhaps from fast4x. You shouldn't always assume that your solution is the best. I believe the best, albeit most demanding, solution would be a fully customizable editor (including a preview window) for the Player Page. This would allow users to mix and match elements to their liking. 'Modern' and 'Essential' modes could be easily selectable presets, along with a 'Custom' option. This way, everyone would be satisfied -except for fast4x, who has to program all this stuff 🤣. |
Well, I said what I want. I know it won't be changed so that's why I spoke my mind. I don't want fast4x to make it universal. If we are talking about options. Maybe this can be implemented
What I request fast4x is to make it universal to have the song's name 'bold' and 'bigger'. If people have problems with this then this can also be optional. |
Yeah this is good. We get to choose icons, names' position, button and cover image shadows etc |
Just like in Nova Launcher. Do you know the app? |
Tried a long time ago. I like simple things so went back to the stock launcher. |
I just wanted to talk about the editor views, because Nova Launcher does it exactly as I described: you have a large preview window, and below it you can adjust all sorts of settings and immediately see what changes. This is very cool and makes all these often cryptic settings very understandable, even for laypeople. Possible settings for the RiMusic Player Page could include:
Additionally, all other existing settings could be incorporated into this editor as well. |
This seems too complicated to implement now. Maybe we should focus on small things.
|
That wasn't a demand; I was just thinking out loud. |
Great, I see with great pleasure that you are talking without fighting and I really like this. For this and other reasons i want to make you happy and to thank you, I will begin to implement some basic functions that over time will allow you to improve and customize the controls of the player. Patience, I will ask for help at fast6x to develop more quickly, but without caring eh... If not, I’ll go completely crazy, at least for now I’m 30% crazy 🤣🤣🤣😂😂😂🤣🤣😂😂🤣🤣 |
...LIAR (110% at least) 😂😂😂!!! But seriously (and I mean it!): don't overwork yourself with this stuff. Give yourself a break for a week or so where you don't do anything. |
Dude...I think we have awakened the true fast4x now. Beast mode activated 😂😂 |
🤣🤣🤣🤣🤣🤣🤣🤣 |
Implemented, controls and artist/album info in modern/essential type, can be used in both rimusic/vimusic mode. |
Other micro customizations for now isn't praticable... |
Steps to reproduce the bug
Open RiMusic.
Navigate to Settings > Player Appearance > Controls Type.
Set the Controls Type to "Essential".
Go to the Player View.
Expected behavior
The Player View should display only the essential controls without redundant extra buttons.
Actual behavior
The Player View shows redundant repeat and like buttons next to the play button.
Screenshots
Suggested Fix
Remove the redundant symbols on the left and right of the play button in the Player View and make the remaining player controls larger, same as > Controls Type > Modern.
RiMusic version
0.6.36.1
Android version
Android 13
The text was updated successfully, but these errors were encountered: