Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If transition effect is changing then it's changing theme also #2319

Closed
Gauravchaubey66 opened this issue Jun 16, 2024 · 14 comments
Closed

If transition effect is changing then it's changing theme also #2319

Gauravchaubey66 opened this issue Jun 16, 2024 · 14 comments
Labels
bug Something isn't working Fixed

Comments

@Gauravchaubey66
Copy link

Steps to reproduce the bug

  1. Open setting
  2. Go to ui
  3. Change theme to material you
  4. Then then transition effect to any other (expect selected one)
Project_06-16_HD.720p_LOW_FR30.mp4

Expected behavior

There should be only change occurs in transition effect but it's changing the Theme also

Actual behavior

Changing trabsiton effect is also changing theme

Screenshots/Screen recordings

I tries with all combination and notices that it's only occurs with dynamic and material you thing.

Logs

No response

RiMusic version

0.6.39

Android version

Android 13

Additional information

No response

@Gauravchaubey66 Gauravchaubey66 added the bug Something isn't working label Jun 16, 2024
@Gauravchaubey66
Copy link
Author

Hey @fast4x here is another bug 🐛 which I found 😁

@twistios
Copy link

twistios commented Jun 18, 2024

I am not 100% sure what this bug is about but the theme looks different on my device (maybe this is the point of it?). But I think I reproduced it on my physical device.

rimusic_material_you_transition_bug.mp4

This is using the "fresh" install on physical device via Android Studio.

@Gauravchaubey66
Copy link
Author

Gauravchaubey66 commented Jun 18, 2024

I am not 100% sure what this bug is about but the theme looks different on my device (maybe this is the point of it?). But I think I reproduced it on my physical device.

rimusic_material_you_transition_bug.mp4

This is using the "fresh" install on physical device via Android Studio.

Thanks buddy actually it's a bug let me explain if we want to change theme that should change theme of the app in dark, light or whatever options that app has it has nothing to do with the animation change . and that thing is occurring here. I hope you get my point.

@twistios
Copy link

twistios commented Jun 18, 2024

There is also a (strange) interaction between material you and theme mode. If you set dark theme and switch to different theme and then switch back it changes theme mode to system.

@twistios
Copy link

twistios commented Jun 18, 2024

I just now tried to test this bug on my AVD but suddenly it crashes/disappears/shuts down (the AVD).

@Gauravchaubey66
Copy link
Author

There is also a (strange) interaction between material you and theme mode. If you set dark theme and switch to different theme and then switch back it changes theme mode to system.

Yeah I noticed it too.😁 just open an another issue from your side.👍

@twistios
Copy link

I am now upgrading my emulator and other Android SDK and software tools, maybe it helps.

I just now tried to test this bug on my AVD but suddenly it crashes/disappears/shuts down (the AVD).

@Gauravchaubey66
Copy link
Author

I just now tried to test this bug on my AVD but suddenly it crashes/disappears/shuts down (the AVD).

Crashes/disappears or shutdown maybe this is cause of AVD. I am unsure about it but I tried in 4 to 5 devices and it's occurring.

@twistios
Copy link

The errors I get are getting weirder by the minute. Finally my SDK and emulation was updated and then an unexpected reboot of my maschine happend when I was just starting the AVD again.

@Gauravchaubey66
Copy link
Author

The errors I get are getting weirder by the minute. Finally my SDK and emulation was updated and then an unexpected reboot of my maschine happend when I was just starting the AVD again.

It's ok take your time resolve your Android studio problems then check it whenever your problems resolved and if is there any thing in which I can help let me know I will be happy 👍

@twistios
Copy link

The effect of this bug depends on serval variables: Android System Theme (tested with light mode) and RiMusic Theme mode.
So here are two videos via my AVD.

  1. Android Light mode and RiMusic Theme mode system
  2. Android Light mode and RiMusic Theme mode dark
rimusic_material_you_transition_bug_avd_light_light.mp4
rimusic_material_you_transition_bug_avd_light_dark.mp4

@Gauravchaubey66
Copy link
Author

Project_06-18_SD.360p_LOW_FR24.mp4

@Gauravchaubey66
Copy link
Author

Project_06-18.1._SD.360p_HIGH_FR30.mp4

@fast4x fast4x added the Fixed label Jul 18, 2024
@fast4x
Copy link
Owner

fast4x commented Jul 18, 2024

Fixed, available from version 0.6.44

fast4x added a commit that referenced this issue Jul 19, 2024
@fast4x fast4x closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed
Projects
None yet
Development

No branches or pull requests

3 participants