Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Picks dont have Related albums & Similar artist #504

Closed
faustaahmad opened this issue Jan 26, 2024 · 12 comments
Closed

Quick Picks dont have Related albums & Similar artist #504

faustaahmad opened this issue Jan 26, 2024 · 12 comments
Labels
bug Something isn't working implemented Feature or request have been developed Not a bug

Comments

@faustaahmad
Copy link

faustaahmad commented Jan 26, 2024

Steps to reproduce the bug

Enable All Quick Picks
Most played song or Last played added song must not registered in Youtube Music, mine from Youtube not music
Settings > Quick Picks > Tips:By Most played song

Expected behavior

Related albums & Similar artist should be visible

Actual behavior

I doesnt appear, perhaps because of the song isnt registered in Youtube Music

Screenshots/Screen recordings

RiMusic version

0.6.19

Android version

Android 11

Suggestion

Fallback to Most played song that are registered in Youtube Music

Since radio works, and mixed with some of songs that are registered on Youtube Music
Try to find closest music on radio that are registered on Youtube Music
Then use that song as source for Tips, Related albums, and Similar artist
While still displaying that one Most played song or Last played song

@faustaahmad faustaahmad added the bug Something isn't working label Jan 26, 2024
@fast4x
Copy link
Owner

fast4x commented Jan 26, 2024

Do you have enabled It in Quick Picks settings?

@faustaahmad
Copy link
Author

Obviously all of 'em

@NEVARLeVrai
Copy link

NEVARLeVrai commented Jan 27, 2024

Do you have enabled It in Quick Picks settings?

I have the same issue with my godfather actually listens to youtube videos so no album or artist is offered I think it's not a issue

For me for example I was listening to music so he offered me some albums and artists

Screenshot_2024-01-27-10-54-50-191_it.fast4x.rimusic.jpg

@faustaahmad
Copy link
Author

No sound, all Quick Picks related settings enabled

456d-8cff-41cc-8104-0855109e15f5.webm

@fast4x
Copy link
Owner

fast4x commented Jan 28, 2024

Check in settings > Quick Picks tab

@NEVARLeVrai
Copy link

If u listen from YT video you don't have related albums ? I think it's it's YT music you have

@faustaahmad
Copy link
Author

faustaahmad commented Jan 28, 2024

I dont think it's neccesary for me to give this information, as it's far too simple & enabled by default

Screenshot_20240128-210614

Try music on Youtube, but not registered on Youtube music
Well... even if it registered, still wont work anyway IF using Last played

As far my test goes, it's not Last played but Last added songs to the library that's played

@NEVARLeVrai only Youtube Music has suggestion, not all Youtube channel registered in Youtube Music

@fast4x
Copy link
Owner

fast4x commented Jan 28, 2024

Try to refresh this settings try again

@faustaahmad
Copy link
Author

I tried enable/disable Quick Picks settings still the same
However, if I reset Quick Picks the problem will temporarily fixed the problem for Last played
But it'll reset Most played song too, which sad

Also, I mentioned in #505 That Last played is bugged (see my previous comment in this issue)

@fast4x
Copy link
Owner

fast4x commented Jan 28, 2024

Ok thanks, I'll investigate it

@fast4x
Copy link
Owner

fast4x commented Feb 1, 2024

Improved most and last played
Available from version 0.6.20

@fast4x fast4x added the implemented Feature or request have been developed label Feb 1, 2024
fast4x added a commit that referenced this issue Feb 2, 2024
@faustaahmad
Copy link
Author

Tested 0.6.20
Last Played behavior still works like before (both in Quick Picks & ⬈ Last played)
They use Last added song that is played, instead of Last played song regardless of new/old (idk how to explain)

Since I cant explain well
Example Quick Picks:

Assume
Last Played on Quick Picks (QP)
Min listening time = 0s
A, B, C as New songs

Play A ~> QP = A
Play B ~> QP = B
- Play A ~> QP = B (Current behavior)
+ Play A ~> QP = A (Desired behavior)
Play C ~> QP = C
- Play A ~> QP = C (Current behavior)
+ Play A ~> QP = A (Desired behavior)

As for ⬈ songs (Last played), it works like Quick Picks as I explained above

[C
,B
,A
,Unchanged List from Last added songs]

But I'm sure if one of 'em get fixed, the other one will be fixed too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working implemented Feature or request have been developed Not a bug
Projects
None yet
Development

No branches or pull requests

3 participants