Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Today" Listening Statistics doesn't reset at 00:00 in some countries #561

Closed
OrangeZXZ opened this issue Feb 1, 2024 · 5 comments
Closed
Labels
bug Something isn't working Fixed

Comments

@OrangeZXZ
Copy link

Steps to reproduce the bug

Go in the listening statistics

Expected behavior

Not showing songs I listened the day before

Actual behavior

It only reset from 7:00 - 12:00 (In France)

Screenshots/Screen recordings

Screenshot_20240201_061813

I took this screenshots at 6:00 but the songs in it were listened the day before at 18:00

Logs

No response

RiMusic version

0.6.19

Android version

Android 14

Additional information

Im not realy sure about the "reset in some countries" i just think it's a UTC problem maybe

@OrangeZXZ OrangeZXZ added the bug Something isn't working label Feb 1, 2024
@OrangeZXZ
Copy link
Author

Let me corect myself it resets after listening 1songs

@fast4x
Copy link
Owner

fast4x commented Feb 1, 2024

From official documentation
Paris is one hour ahead of Greenwich/UTC in winter and two hours ahead in summer. The ZoneId instance for Paris will reference two ZoneOffset instances - a +01:00 instance for winter, and a +02:00 instance for summer.
In 2008, time-zone offsets around the world extended from -12:00 to +14:00. To prevent any problems with that range being extended, yet still provide validation, the range of offsets is restricted to -18:00 to 18:00 inclusive.

@fast4x
Copy link
Owner

fast4x commented Feb 1, 2024

Fammi capire che si ripristina dopo aver ascoltato 1songs

I don't understand

@OrangeZXZ
Copy link
Author

OrangeZXZ commented Feb 1, 2024

Fammi capire che si ripristina dopo aver ascoltato 1songs

I don't understand

If you listen 10 songs then wait 1day you will see those songs because the list d'osent reset at 00:00

But if you listen to 1song the day after those 10 songs. It reset the list

In the screenshot i send the songs shown in the "Today" section d'idnt disappear the next day

A way to patch this is to check if we are the same day and if not the "Today" section gosse back to 0

@fast4x fast4x added the Fixed label Feb 29, 2024
@fast4x
Copy link
Owner

fast4x commented Feb 29, 2024

I think that it's fixed.
Available from version 0.6.24

@fast4x fast4x closed this as completed Mar 1, 2024
fast4x added a commit that referenced this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed
Projects
None yet
Development

No branches or pull requests

2 participants