Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed double tap to show thumbnail bug #2401

Merged
merged 11 commits into from
Jun 24, 2024
Merged

fixed double tap to show thumbnail bug #2401

merged 11 commits into from
Jun 24, 2024

Conversation

aneesh1122
Copy link

@aneesh1122 aneesh1122 commented Jun 21, 2024

  1. added option to disable lyrics outline/stroke New Expanded Player view doesnt work #2399
  2. disabled expanded player when showlyricsthumbnail is enabled and also for landscape mode New Expanded Player view doesnt work #2399
  3. fixed double tap to show thumbnail bug
  4. added space between timeline and action bar when action bar is not transparent New Expanded Player view doesnt work #2399
  5. Moved lyrics color and outline to lyrics settings
  6. added fluid rainbow lyrics color
  7. added fluid rainbow lyrics outline
  8. [added option to have black gradient at bottom when gradient background is chosen] (470f470)
    Player Screen Colour Platelets #2432
  9. added glow to lyrics

@aneesh1122
Copy link
Author

wait. don't merge it now. it seems to be causing some problems. I'll fix the issue and let you know

2) disabled expanded player when showlyricsthumbnail is enabled.
@aneesh1122
Copy link
Author

@fast4x now you can merge it

@aneesh1122
Copy link
Author

I tried to disable expanded player also for landscape mode but I'm not able to do it. I'm either able to disable it for showlyricsthumbnail or isLandscape but not both. This is the condition I'm using. Please tell me what's wrong with it

if ((expandedplayer && !showlyricsthumbnail) || (expandedplayer && !isLandscape))

@aneesh1122
Copy link
Author

Finally managed to disable it also for landscape mode.

Don't worry. Landscape mode has this lyrics view
Screenshot_2024-06-22-15-13-40-739_it.fast4x.rimusic.debug.jpg

And it also has old full screen lyrics in case someone is using thumbnail for lyrics

@aneesh1122
Copy link
Author

Moved lyrics color and outline to lyrics settings

Screenshot_2024-06-22-17-24-11-291_it.fast4x.rimusic.debug-edit.jpg

@aneesh1122
Copy link
Author

I did a fun little experiment. So, do you want to add this?

VID_20240622_192522.mp4

@aneesh1122
Copy link
Author

What about this one?

VID_20240622_205021.mp4

@Wjxfi
Copy link

Wjxfi commented Jun 22, 2024

I luv it

@aneesh1122
Copy link
Author

Just to be clear I've deleted the static rainbow and added only the moving rainbow gradient.

Do you guys want me to add both the moving and static rainbow colors?

@aneesh1122
Copy link
Author

aneesh1122 commented Jun 23, 2024

VID_20240624_004323.mp4

@fast4x fast4x merged commit 72c2247 into fast4x:master Jun 24, 2024
@fast4x
Copy link
Owner

fast4x commented Jun 24, 2024

Merged, thanks for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants