made showthumbnail compulsory for playerBackgroundColors != PlayerBackgroundColors.BlurredCoverColor #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kgroundColors.BlurredCoverColor
|
This is how it works VID_20240628_001133.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can already see many people creating issues because they don't have thumbnail in their player. Last week someone created an issue saying that expanded player is not working. I had to disable expanded player for people who are using this app the old way.
So I made
showthumbnail = truecompulsory for non-cover backgrounds. as soon as they switch to some other background other than 'PlayerBackgroundColors.BlurredCoverColor' showthumbnail will become true and then I've hidden this option for non-cover backgrounds so they can't change it unless they change the background back toBlurredCoverColor.Believe me, this will save us two a lot of headache.