Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added swipe to see next thumbnail in full screen cover mode #2906

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

aneesh1122
Copy link

fixes #2667

@fast4x fast4x merged commit 7b55138 into fast4x:master Jul 24, 2024
@aneesh1122
Copy link
Author

@fast4x I was trying to implement #1321 but I'm not able to. The app is crashing. Need to change thing in database.

Please try to implement this. I've requested it 4 months ago

@fast4x
Copy link
Owner

fast4x commented Jul 24, 2024

Database not must change at least for now

@aneesh1122
Copy link
Author

Database not must change at least for now

I'm not sure if it require changing database. could you look at it once?

filteredSongs = songs
                .filter {
                    it.title.contains(filterCharSequence,true) ?: false
                            || it.artistsText?.contains(filterCharSequence,true) ?: false

this is the code which filters songs.

@fast4x
Copy link
Owner

fast4x commented Jul 24, 2024

this not require database

@aneesh1122
Copy link
Author

this not require database

that's what I thought. I just assumed it will require database. will you look at it?

@aneesh1122
Copy link
Author

this not require database

I changed code

if (!filter.isNullOrBlank())
        playlistSongs =
            playlistSongs.filter { songItem ->
                songItem.asMediaItem.mediaMetadata.title?.contains(
                    filterCharSequence,
                    true
                ) ?: false
                        || songItem.asMediaItem.mediaMetadata.artist?.contains(
                    filterCharSequence,
                    true
                ) ?: false
                        || songItem.asMediaItem.mediaMetadata.albumTitle?.contains(  //added by me
                    filterCharSequence,
                    true
                ) ?: false
            }

but it's still not working

@fast4x
Copy link
Owner

fast4x commented Jul 24, 2024

I'll check it

@aneesh1122
Copy link
Author

I'll check it

Okay. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swipe to see the thumbnail of the next song
2 participants