Adds textoutline for "totalPlayTimes" #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make it optional in player appearance like textoutline for lyrics |
|
Does it have to be optional? Currently it gets activated and deactivated with the default textoutline setting, that also affects the text for the controls. Or should this be for customizability? |
|
You’re right I was remembering wrong, it's ok in settings |
|
good job @twistios. I actually overlooked queue total time because I never use it. |
|
Merged, good work, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See examples.
Beggin
Comfortably Numb
This is an example where my recent ideas would have helped. I also found out that merge works reliably with good results while the idea with inferring (and therefore ability not to state all fields) without merge did NOT actually work.