-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added textoutline for "SelectorArtistsDialog" #3136
added textoutline for "SelectorArtistsDialog" #3136
Conversation
There is also an
I can also fix this directly or not if you don't like me to @fast4x. |
Good job but there's one problem though. This outline will appear only if you have the song cover as background(That's how I've coded it) I think you should remove the text outline and add a gradient and make it permanent. |
Nope. Seems like I accidentally made it work with that also or do you mean something else? @aneesh1122 |
Ah, I see. It is one of these settings that stay activated even if the settings option is gone. And because I have activated it with background cover, it still was active. |
Yeah. So If someone wants to deactivate it they have to change the player background to Album cover again. So just remove the outline and add a small gradient at the bottom and make it permanent. |
I think that this should rather be a change in the settings as the text outline stays enabled also at the other places. |
I don't think anything should be changed in settings because text outline is added only for album cover background. It doesn't make sense anywhere else because there's no text visibility problems so text outline option should be visible only when cover background is chosen. If you really want text outline so bad then remove the condition of textoutline and make it permanent. |
See examples.
Light mode
Dark mode
I used the same colors as everywhere else so if you don't like it with light mode then it is not my fault.
@aneesh1122 you also forgot this menu. 😄
I think the same is also true for the visualizer controls.