Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added textoutline for "SelectorArtistsDialog" #3136

Merged

Conversation

twistios
Copy link

@twistios twistios commented Aug 5, 2024

See examples.

Light mode

goodboys_no_outline
goodboys_outline

Dark mode

don_diabolo_no_outline
don_diabolo_outline

I used the same colors as everywhere else so if you don't like it with light mode then it is not my fault.

@aneesh1122 you also forgot this menu. 😄
I think the same is also true for the visualizer controls.

@twistios
Copy link
Author

twistios commented Aug 5, 2024

There is also a bug that the artist image does not load unless you have been on the artist page already.

Details

dazy_no_image
dazy_with_image

@twistios
Copy link
Author

twistios commented Aug 5, 2024

There is also an Suspicious indentation error in the file (Dialog.kt).

Suspicious indentation: This is indented but is not continuing the previous expression (val colorPaletteMode...) (Previous statement here)

I can also fix this directly or not if you don't like me to @fast4x.

@fast4x fast4x merged commit 91d5011 into fast4x:master Aug 5, 2024
@aneesh1122
Copy link

Good job but there's one problem though. This outline will appear only if you have the song cover as background(That's how I've coded it)

I think you should remove the text outline and add a gradient and make it permanent.

@twistios
Copy link
Author

twistios commented Aug 6, 2024

Nope. Seems like I accidentally made it work with that also or do you mean something else? @aneesh1122
Screenshot_20240806_100942

@twistios
Copy link
Author

twistios commented Aug 6, 2024

Ah, I see. It is one of these settings that stay activated even if the settings option is gone. And because I have activated it with background cover, it still was active.
So the toggle is gone in that case.

@aneesh1122
Copy link

Ah, I see. It is one of these settings that stay activated even if the settings option is gone. And because I have activated it with background cover, it still was active.
So the toggle is gone in that case.

Yeah. So If someone wants to deactivate it they have to change the player background to Album cover again.

So just remove the outline and add a small gradient at the bottom and make it permanent.

@twistios
Copy link
Author

twistios commented Aug 6, 2024

I think that this should rather be a change in the settings as the text outline stays enabled also at the other places.

@aneesh1122
Copy link

I think that this should rather be a change in the settings as the text outline stays enabled also at the other places.

I don't think anything should be changed in settings because text outline is added only for album cover background. It doesn't make sense anywhere else because there's no text visibility problems so text outline option should be visible only when cover background is chosen.

If you really want text outline so bad then remove the condition of textoutline and make it permanent.

@twistios twistios deleted the patch_SelectorArtistsDialog_textoutline branch September 20, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants