Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded pydantic and fast api to last version. Fixed ORM mode and EmailStr imports #100

Closed
wants to merge 2 commits into from
Closed

Upgraded pydantic and fast api to last version. Fixed ORM mode and EmailStr imports #100

wants to merge 2 commits into from

Conversation

acidjunk
Copy link

Some small changes to get this working with current versions of pydantic /fast api.

@acidjunk acidjunk requested a review from tiangolo January 17, 2020 13:51
@nareto nareto mentioned this pull request Jan 19, 2020
Closed
ebreton
ebreton reviewed Jan 26, 2020
View reviewed changes
Copy link
Contributor

@ebreton ebreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acidjunk ,

The last merged PR as fixed most of the stuff you had pointed out (if not everything). Would you mind to update your branch and double-check if there has been anything left out ?

@StephenBrown2
Copy link
Contributor

@tiangolo Fixed in #23?

@acidjunk
Copy link
Author

Let's close this one: will check the last master version.

@acidjunk acidjunk closed this Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebreton ebreton ebreton left review comments

@tiangolo tiangolo Awaiting requested review from tiangolo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acidjunk @StephenBrown2 @ebreton