Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email validation #40

Merged
merged 4 commits into from
Apr 6, 2020
Merged

Add email validation #40

merged 4 commits into from
Apr 6, 2020

Conversation

kedod
Copy link
Contributor

@kedod kedod commented Jun 13, 2019

Add email validation in User model with pydantic EmailStr.

Btw have you considered using pipenv or requirements.txt files for python packages dependencies?
Installing packages one by one in dockerfiles is kind of ugly.

@stratosgear
Copy link

Just saw your comment about pipenv, after I have already opened issue #69, already asking the same question...

Your PR looks nice btw!

@StephenBrown2
Copy link
Contributor

@tiangolo Fixed in #23?

@tiangolo tiangolo merged commit 970a182 into fastapi:master Apr 6, 2020
@tiangolo
Copy link
Member

tiangolo commented Apr 6, 2020

Thanks for the discussion here everyone!

About Pipenv and installing in Dockerfiles, I'm still not completely happy with how these package dependency management tools work. For example, Pipenv is currently not very well maintained, I plan to switch to Poetry instead.

But also, installing in Dockerfiles lets you iterate quickly and take advantage of the Docker cache. For example, if you want to test a new Python package, you could add a line to your Dockerfile and build again, without having to wait for it to install everything from scratch.

But again, as I'm not entirely happy with all this yet, I don't want to "recommend" one way or another. So, for the moment, I suggest you update your local system to use the tools and workflow of your preference (requirements.txt, Pipenv, Poetry, etc.).


About this PR, yeah, #23 included some parts but I simplified it to have the minimum, as it covered a lot of different things in a single PR.

I just updated this PR to rebase it from the latest changes.

Thanks for your contribution @kedod ! 🚀 🎉 🍰

gusevyaroslove pushed a commit to gusevyaroslove/fastapi-template that referenced this pull request Aug 4, 2024
* modify tests

* ➕ Add email-validator to Dockerfiles

* ♻️ Update random email generation

* ♻️ Re-apply email validation after rebase

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
alejsdev added a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants