Support existing click.ParamType instance in type hint #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📝 Docs preview for commit addbc63 at: https://639cea76d8175d0bb72d5f48--typertiangolo.netlify.app |
|
Thanks! Support for this was added in #583, the new docs are here: https://typer.tiangolo.com/tutorial/parameter-types/custom-types/, it's available in Typer Given that, I'll close this one, but thanks for your effort! 🍰 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a custom
KeyValueType(click.ParamType)we used inclick.option(..., type=KeyValueType())forkey=valuestyle flags. When converting totyper, I was hoping to be able to set these in the param type hint, but ran intoRuntimeError(f"Type not yet supported: {annotation}"). Adding this extra check fixed my use, and I'm guessing any other customParamTypes?Is this the right place/way to add this support? If so, happy to dig into how to add a test for this!
cc @rockwellw