-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Improve support for CLI translations using gettext #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just chiming in to say that it would be nice to have this one merged :)
Edit: this PR might also consider removing the TODO
about this very change: https://github.com/tiangolo/typer/blob/046d3e2b4cb1f2feb6d94b856aa75e013d9896c6/typer/core.py#L623-L626
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I took the liberty of updating your PR with the latest changes from master
. This looks good to me.
Thanks @svlandeg! I do wonder if we should also update some of the strings at https://github.com/tiangolo/typer/blob/74433d22b489d13fe1a0bb1f6729127cfa942996/typer/rich_utils.py#L83-L93 If you are fine with it I can create a PR if you don't want to update this one with those. |
Good idea to add those @ereslibre - I've pushed directly to this PR to keep the work together. Feel free to review! |
@tiangolo did beat me to it! Sorry for the lag on the review and thank you everyone involved :) |
Just adding some missing wrappings of strings around gettext which some may need for the sake of CLI i18n.