Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆ Bump ruff from 0.2.0 to 0.6.1 #938

Merged
merged 10 commits into from
Aug 28, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 19, 2024

Bumps ruff from 0.2.0 to 0.6.1.

Release notes

Sourced from ruff's releases.

0.6.1

Release Notes

This is a hotfix release to address an issue with ruff-pre-commit. In v0.6, Ruff changed its behavior to lint and format Jupyter notebooks by default; however, due to an oversight, these files were still excluded by default if Ruff was run via pre-commit, leading to inconsistent behavior. This has now been fixed.

Preview features

  • [fastapi] Implement fast-api-unused-path-parameter (FAST003) (#12638)

Rule changes

  • [pylint] Rename too-many-positional to too-many-positional-arguments (R0917) (#12905)

Server

  • Fix crash when applying "fix-all" code-action to notebook cells (#12929)

Other changes

  • [flake8-naming]: Respect import conventions (N817) (#12922)

Contributors

Install ruff 0.6.1

Install prebuilt binaries via shell script

curl --proto '=https' --tlsv1.2 -LsSf https://github.com/astral-sh/ruff/releases/download/0.6.1/ruff-installer.sh | sh

Install prebuilt binaries via powershell script

powershell -c "irm https://github.com/astral-sh/ruff/releases/download/0.6.1/ruff-installer.ps1 | iex"

Download ruff 0.6.1

File Platform Checksum
ruff-aarch64-apple-darwin.tar.gz Apple Silicon macOS checksum
ruff-x86_64-apple-darwin.tar.gz Intel macOS checksum

... (truncated)

Changelog

Sourced from ruff's changelog.

0.6.1

This is a hotfix release to address an issue with ruff-pre-commit. In v0.6, Ruff changed its behavior to lint and format Jupyter notebooks by default; however, due to an oversight, these files were still excluded by default if Ruff was run via pre-commit, leading to inconsistent behavior. This has now been fixed.

Preview features

  • [fastapi] Implement fast-api-unused-path-parameter (FAST003) (#12638)

Rule changes

  • [pylint] Rename too-many-positional to too-many-positional-arguments (R0917) (#12905)

Server

  • Fix crash when applying "fix-all" code-action to notebook cells (#12929)

Other changes

  • [flake8-naming]: Respect import conventions (N817) (#12922)

0.6.0

Check out the blog post for a migration guide and overview of the changes!

Breaking changes

See also, the "Remapped rules" section which may result in disabled rules.

  • Lint and format Jupyter Notebook by default (#12878).
  • Detect imports in src layouts by default for isort rules (#12848)
  • The pytest rules PT001 and PT023 now default to omitting the decorator parentheses when there are no arguments (#12838).

Deprecations

The following rules are now deprecated:

Remapped rules

The following rules have been remapped to new rule codes:

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ruff](https://github.com/astral-sh/ruff) from 0.2.0 to 0.6.1.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@v0.2.0...0.6.1)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Aug 19, 2024
@svlandeg svlandeg self-assigned this Aug 21, 2024
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To upgrade to ruff 0.6.1, we need to add the following changes as well:

  • Use f-strings for the Click examples. We already wanted to this: ♻️ Use F-strings in Click examples in docs #891 so this edit should be fine
  • Update 4 cases of a == check to an is comparison for the type check. The latter seems more correct to me, so this edit seems fine as well
  • Update some of the formatting across the repo (3 files reformatted)

The first 2 fixes are an improvement IMO, and the slight change in formatting is not so dramatic. As such, I think it's worth considering doing the upgrade.

@svlandeg svlandeg marked this pull request as draft August 21, 2024 14:43
Copy link

📝 Docs preview for commit 52722d0 at: https://b5ffd922.typertiangolo.pages.dev

@svlandeg svlandeg marked this pull request as ready for review August 21, 2024 15:01
@svlandeg
Copy link
Member

Hm, I'm confused why the pre-commit.ci check errors out with a

timeout waiting for merge ref

🤔

@svlandeg svlandeg removed their assignment Aug 21, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 23, 2024

A newer version of ruff exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@svlandeg svlandeg self-assigned this Aug 26, 2024
@svlandeg svlandeg marked this pull request as draft August 26, 2024 10:10
@svlandeg svlandeg marked this pull request as ready for review August 27, 2024 09:14
@svlandeg svlandeg removed their assignment Aug 27, 2024
@tiangolo tiangolo merged commit 7d6db83 into master Aug 28, 2024
23 checks passed
@tiangolo tiangolo deleted the dependabot/pip/ruff-0.6.1 branch August 28, 2024 23:25
@tiangolo
Copy link
Member

Great, thank you @svlandeg! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants