Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking: Don't Require A Live Connection #8

Closed
brandtbucher opened this issue Oct 14, 2021 · 4 comments
Closed

Benchmarking: Don't Require A Live Connection #8

brandtbucher opened this issue Oct 14, 2021 · 4 comments
Assignees

Comments

@brandtbucher
Copy link
Member

(Follows from my discussion with @ericsnowcurrently earlier today.)

Currently, our benchmark runner will fail if the submitting user's SSH connection closes for any reason. If it's not too difficult, we should try to gracefully handle dropped connections and continue running the user's current job.

@gvanrossum
Copy link
Contributor

Yes, I have lived in fear of disconnecting.

@ericsnowcurrently ericsnowcurrently self-assigned this Apr 13, 2022
@mdboom
Copy link
Contributor

mdboom commented Apr 14, 2022

Maybe there's someway screen or tmux could be helpful here.

@ericsnowcurrently
Copy link
Collaborator

Yeah, I considered that (and that's what I do personally). However, if we're adding a job queue (#8) then we'll need to be able to run jobs in the background, which requires this feature. 'tmux' won't help as much with that.

@ericsnowcurrently
Copy link
Collaborator

Implemented in #17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants