Merge pull request #15 from mcollina/option-to-override

Pass options object to override function

README.md

@@ -277,11 +277,11 @@ boot(app, {
 -------------------------------------------------------
 <a name="override"></a>
 
-### app.override(server, plugin)
+### app.override(server, plugin, options)
 
 Allows to override the instance of the server for each loading plugin.  
 It allows the creation of an inheritance chain for the server instances.  
-The first parameter is the server instance and the second is the plugin function.
+The first parameter is the server instance and the second is the plugin function while the third is the options object that you give to use.
 
 ```js
 const boot = require('avvio')
@@ -291,7 +291,7 @@ const app = boot(server)
 
 console.log(app !== server, 'override must be set on the Avvio instance')
 
-app.override = function (s, fn) {
+app.override = function (s, fn, opts) {
   // create a new instance with the
   // server as the prototype
   const res = Object.create(s)

boot.js

@@ -108,7 +108,7 @@ Boot.prototype._init = function () {
 }
 
 // allows to override the instance of a server, given a plugin
-Boot.prototype.override = function (server, func) {
+Boot.prototype.override = function (server, func, opts) {
   return server
 }
 
@@ -191,7 +191,7 @@ function Plugin (parent, func, opts, callback) {
 
 Plugin.prototype.exec = function (server, cb) {
   const func = this.func
-  this.server = this.parent.override(server, func)
+  this.server = this.parent.override(server, func, this.opts)
   func(this.server, this.opts, cb)
 }
 

test/override.js

@@ -183,3 +183,27 @@ test('skip override - fastify test case', (t) => {
     cb()
   }
 })
+
+test('override can receive options object', (t) => {
+  t.plan(4)
+
+  const server = { my: 'server' }
+  const options = { hello: 'world' }
+  const app = boot(server)
+
+  app.override = function (s, fn, opts) {
+    t.equal(s, server)
+    t.deepEqual(opts, options)
+
+    const res = Object.create(s)
+    res.b = 42
+
+    return res
+  }
+
+  app.use(function first (s, opts, cb) {
+    t.notEqual(s, server)
+    t.ok(server.isPrototypeOf(s))
+    cb()
+  }, options)
+})