Close should not need a callback

fastify · Jul 13, 2017 · e9441cc · e9441cc
1 parent 4371240
commit e9441cc
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/boot.js b/boot.js
@@ -189,7 +189,9 @@ Boot.prototype.onClose = function (func) {
 
 Boot.prototype.close = function (cb) {
   this._error = null
-  this._closeQ.push(cb)
+  if (cb) {
+    this._closeQ.push(cb)
+  }
   process.nextTick(this._closeQ.resume.bind(this._closeQ))
 }
 

diff --git a/test/close.js b/test/close.js
@@ -143,3 +143,16 @@ test('close order', (t) => {
     })
   })
 })
+
+test('close without a cb', (t) => {
+  t.plan(1)
+
+  const app = boot()
+
+  app.onClose((err, instance, done) => {
+    t.error(err)
+    done()
+  })
+
+  app.close()
+})