Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement error factory #145

Merged
merged 3 commits into from
May 24, 2021
Merged

feat: implement error factory #145

merged 3 commits into from
May 24, 2021

Conversation

metcoder95
Copy link
Member

@metcoder95 metcoder95 commented May 13, 2021 •
edited
Loading

Implements Fastify#2842

Checklist

@metcoder95 metcoder95 marked this pull request as ready for review May 18, 2021 21:02
mcollina
mcollina approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

I think this should be semver-major.

@metcoder95
Copy link
Member Author

Agree, I'll change branch target to next branch

@metcoder95 metcoder95 changed the base branch from master to next May 20, 2021 20:10
@metcoder95
Copy link
Member Author

Done, for some reason it says is up-to-date but marks all those commits out of nowhere

@mcollina
Copy link
Member

mcollina commented May 21, 2021 •
edited
Loading

next did not have all the commits, I just brought next up to date with master.

@mcollina
Copy link
Member

Can you push again? I'm sorry

@metcoder95 metcoder95 force-pushed the feat/improve-error-experience branch from b4d8266 to 58c07e5 Compare May 22, 2021 22:24
@metcoder95
Copy link
Member Author

Done! Thanks 👍

@metcoder95 metcoder95 requested a review from mcollina May 24, 2021 15:46
mcollina
mcollina approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 558e656 into fastify:next May 24, 2021
@kibertoad kibertoad mentioned this pull request Sep 4, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metcoder95 @mcollina