Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the error only inside the close callback #19

Merged
merged 2 commits into from
Jul 13, 2017
Merged

Expose the error only inside the close callback #19

merged 2 commits into from
Jul 13, 2017

Conversation

delvedor
Copy link
Member

As titled

@delvedor delvedor requested a review from mcollina July 13, 2017 16:36
mcollina
mcollina reviewed Jul 13, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does all onClose and .close() callback get called even in the case of an error?

@delvedor
Copy link
Member Author

Yes, I've also added a test to cover that.

@mcollina
Copy link
Member

LGTM

@delvedor delvedor merged commit 2abb9fa into master Jul 13, 2017
@delvedor delvedor deleted the error-close branch July 13, 2017 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delvedor @mcollina