fix codesmell in callWithCbOrNextTick and closeWithCbOrNextTick #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
changed the title
mcollina
reviewed
Aug 23, 2022
Comment on lines
+405
to
+406
| function callWithCbOrNextTick (func, cb) { | ||
| const context = this._server |
There was a problem hiding this comment.
this is never called with the 3rd argument?
There was a problem hiding this comment.
never called with 3rd argument
| @@ -467,8 +467,8 @@ function timeoutCall (func, rootErr, context, cb) { | |||
| } | |||
| } | |||
|
|
|||
| function closeWithCbOrNextTick (func, cb, context) { | |||
| context = this._server | |||
| function closeWithCbOrNextTick (func, cb) { | |||
There was a problem hiding this comment.
this is never called with the 3rd argument?
There was a problem hiding this comment.
never called with 3rd argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct