Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synchronize with fastify-errors #197

Merged
merged 1 commit into from
Dec 5, 2022
Merged

synchronize with fastify-errors #197

merged 1 commit into from
Dec 5, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Dec 4, 2022

Checklist

@mcollina
Copy link
Member

mcollina commented Dec 4, 2022

why this change?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Dec 5, 2022

It would be the same like in fastify-error
https://github.com/fastify/fastify-error/blob/e4b4bd1aa0f4aa9914fd4fc0160d71a51bfcbf20/index.js#L12

Thats all

mcollina
mcollina approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit f978a78 into master Dec 5, 2022
@Uzlopak Uzlopak deleted the synchronize-with-fastify-error branch December 5, 2022 09:49
@Uzlopak Uzlopak mentioned this pull request Jun 24, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Awaiting requested review from Eomm

@climba03003 climba03003 Awaiting requested review from climba03003

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @mcollina