Fix error code of AVV_ERR_ROOT_PLG_BOOTED

[mbelsky]

Hi there,

I believe there is a typo. This PR fixes it.

By making a contribution to this project, I certify that:

• (a) The contribution was created in whole or in part by me and I
  have the right to submit it under the open source license
  indicated in the file; or

• (b) The contribution is based upon previous work that, to the best
  of my knowledge, is covered under an appropriate open source
  license and I have the right under that license to submit that
  work with modifications, whether created in whole or in part
  by me, under the same open source license (unless I am
  permitted to submit under a different license), as indicated
  in the file; or

• (c) The contribution was provided directly to me by some other
  person who certified (a), (b) or (c) and I have not modified
  it.

• (d) I understand and agree that this project and the contribution
  are public and that a record of the contribution (including all
  personal information I submit with it, including my sign-off) is
  maintained indefinitely and may be redistributed consistent with
  this project or the open source license(s) involved.
  -->

Checklist

• run npm run test
• npm run benchmark <-- this command fails with the following error:

$ npm run benchmark                     
npm ERR! Missing script: "benchmark"
npm ERR! 
npm ERR! To see a list of scripts, run:
npm ERR!   npm run

• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[Uzlopak]

Good catch. Can you provide unit tests for this?

[mbelsky]

@Uzlopak sure I can. Usually I don't cover condition-less code with unit tests so would you share any ideas what should be tested here?

As an alternative I can rewrite the error definitions in a copy-paste errors proof way:

const errors = {}

[
  ["error_name", "error_description"],
  …
].forEach(([name, description]) => {
  errors[name] = createError(name, description)
})

module.exports = {
  createError,
  ...errors,
}

[Eomm]

any ideas what should be tested here?

I would just iterate the object's entries and check prop-key vs error code tbh or - how did you spot it? that could be a good test 😄

[Uzlopak]

added unit test