Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove _isOnCloseHandlerKey #231

Merged
merged 3 commits into from
Aug 15, 2023
Merged

chore: remove _isOnCloseHandlerKey #231

merged 3 commits into from
Aug 15, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 14, 2023

We dont need this attribute, when we can refer to the symbol directly

Checklist

mcollina
mcollina approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 4350184 into master Aug 15, 2023
@Fdawgs Fdawgs deleted the remove_isOnCloseHandlerKey branch August 15, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Fdawgs Fdawgs Awaiting requested review from Fdawgs

@kibertoad kibertoad Awaiting requested review from kibertoad

@Eomm Eomm Awaiting requested review from Eomm

@metcoder95 metcoder95 Awaiting requested review from metcoder95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @mcollina